Skip to content

BRP: cancel profile delivery on deletion of profiles in batch via fleetctl gitops #29145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025

Conversation

mna
Copy link
Member

@mna mna commented May 14, 2025

For #29091

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 70.09346% with 32 lines in your changes missing coverage. Please review.

Project coverage is 64.27%. Comparing base (ecfb551) to head (fde4c49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/apple_mdm.go 71.42% 14 Missing and 6 partials ⚠️
server/datastore/mysql/microsoft_mdm.go 67.56% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29145   +/-   ##
=======================================
  Coverage   64.26%   64.27%           
=======================================
  Files        1840     1840           
  Lines      178828   178884   +56     
  Branches     5160     5158    -2     
=======================================
+ Hits       114932   114972   +40     
- Misses      54866    54876   +10     
- Partials     9030     9036    +6     
Flag Coverage Δ
backend 65.24% <70.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mna mna temporarily deployed to Docker Hub May 14, 2025 20:03 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 20:03 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 20:51 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 20:57 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 20:57 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 21:40 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 14, 2025 21:40 — with GitHub Actions Inactive
Base automatically changed from mna-29090-cancel-single-profile-on-delete-1 to main May 20, 2025 12:55
@mna mna force-pushed the mna-29091-cancel-profile-on-batch-delete-2 branch from 7f89b1a to 9965374 Compare May 20, 2025 13:00
@mna mna temporarily deployed to Docker Hub May 20, 2025 13:00 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 20, 2025 13:00 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 20, 2025 14:55 — with GitHub Actions Inactive
@mna mna temporarily deployed to Docker Hub May 20, 2025 14:55 — with GitHub Actions Inactive
@mna mna marked this pull request as ready for review May 20, 2025 15:19
@mna mna requested a review from a team as a code owner May 20, 2025 15:19
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mna mna merged commit 7b9b158 into main May 21, 2025
42 checks passed
@mna mna deleted the mna-29091-cancel-profile-on-batch-delete-2 branch May 21, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants