Wont compile on illumos

[Robert4S]

Fish will not compile on illumos due to it using linux-specific stuff from the libc crate. Specifically, it uses a lot of stuff from libc/unix/linux_like/linux/mod.rs, so it will not compile on IllumOS/OmniOS/OpenIndiana.

[faho]

Can you give us the exact errors?

[zanchey]

Yeah, because Rust's feature detection is pretty basic, there's a lot of cfg directives that use different features on BSD, Darwin, or Linux - these would need extending to IllumOS. @Robert4S do you have any interest in putting a patch together? I think @faho did some work getting OI to work in the past but I don't know if he has any capacity to do so again before 4.0.

[faho]

I think @faho did some work getting OI to work in the past but I don't know if he has any capacity to do so again before 4.0.

Probably not. I'd have to rebuild my test setup, and given that it looks like nobody has tried to compile fish there in the last year (possibly even two), it's not going to be a priority for me.

[Robert4S]

@Robert4S do you have any interest in putting a patch together?

I'm pretty busy at the moment, but I'll see if I can put something together when I get a chance.

[faho]

Okay, here's the errors:

error[E0432]: unresolved imports `libc::posix_spawn_file_actions_t`, `libc::posix_spawnattr_t`
 --> src/fork_exec/spawn.rs:9:20
  |
9 | use libc::{c_char, posix_spawn_file_actions_t, posix_spawnattr_t};
  |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^ no `posix_spawnattr_t` in the root
  |                    |
  |                    no `posix_spawn_file_actions_t` in the root

error[E0432]: unresolved import `libc::strftime`
    --> src/history.rs:1453:17
     |
1453 |             use libc::strftime;
     |                 ^^^^^^^^^^^^^^ no `strftime` in the root

error[E0433]: failed to resolve: could not find `resource` in `sys`
  --> src/builtins/ulimit.rs:18:66
   |
18 |     let resource = unsafe { std::mem::transmute::<i32, nix::sys::resource::Resource>(resource) };
   |                                                                  ^^^^^^^^ could not find `resource` in `sys`

error[E0433]: failed to resolve: could not find `resource` in `sys`
  --> src/builtins/ulimit.rs:19:15
   |
19 |     nix::sys::resource::getrlimit(resource)
   |               ^^^^^^^^ could not find `resource` in `sys`

error[E0433]: failed to resolve: could not find `resource` in `sys`
  --> src/builtins/ulimit.rs:27:66
   |
27 |     let resource = unsafe { std::mem::transmute::<i32, nix::sys::resource::Resource>(resource) };
   |                                                                  ^^^^^^^^ could not find `resource` in `sys`

error[E0433]: failed to resolve: could not find `resource` in `sys`
  --> src/builtins/ulimit.rs:28:15
   |
28 |     nix::sys::resource::setrlimit(resource, rlim_cur, rlim_max)
   |               ^^^^^^^^ could not find `resource` in `sys`

error[E0425]: cannot find function `mkostemp` in crate `libc`
    --> src/fallback.rs:116:24
     |
116  |         unsafe { libc::mkostemp(name, O_CLOEXEC) }
     |                        ^^^^^^^^ help: a function with a similar name exists: `mkstemp`
     |
    ::: /export/home/vagrant/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.169/src/unix/mod.rs:1478:5
     |
1478 |     pub fn mkstemp(template: *mut c_char) -> c_int;
     |     ----------------------------------------------- similarly named function `mkstemp` defined here

error[E0425]: cannot find function `posix_spawnattr_init` in crate `libc`
  --> src/fork_exec/spawn.rs:29:30
   |
29 |             check_fail(libc::posix_spawnattr_init(&mut attr))?;
   |                              ^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawnattr_setflags` in crate `libc`
  --> src/fork_exec/spawn.rs:35:35
   |
35 |         unsafe { check_fail(libc::posix_spawnattr_setflags(&mut self.0, flags)) }
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawnattr_setpgroup` in crate `libc`
  --> src/fork_exec/spawn.rs:39:35
   |
39 |         unsafe { check_fail(libc::posix_spawnattr_setpgroup(&mut self.0, pgroup)) }
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawnattr_setsigdefault` in crate `libc`
  --> src/fork_exec/spawn.rs:43:35
   |
43 |         unsafe { check_fail(libc::posix_spawnattr_setsigdefault(&mut self.0, sigs)) }
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawnattr_setsigmask` in crate `libc`
  --> src/fork_exec/spawn.rs:47:35
   |
47 |         unsafe { check_fail(libc::posix_spawnattr_setsigmask(&mut self.0, sigs)) }
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawnattr_destroy` in crate `libc`
  --> src/fork_exec/spawn.rs:54:27
   |
54 |             let _ = libc::posix_spawnattr_destroy(&mut self.0);
   |                           ^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn_file_actions_init` in crate `libc`
  --> src/fork_exec/spawn.rs:66:30
   |
66 |             check_fail(libc::posix_spawn_file_actions_init(&mut actions))?;
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn_file_actions_addclose` in crate `libc`
  --> src/fork_exec/spawn.rs:72:35
   |
72 |         unsafe { check_fail(libc::posix_spawn_file_actions_addclose(&mut self.0, fd)) }
   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn_file_actions_adddup2` in crate `libc`
  --> src/fork_exec/spawn.rs:77:30
   |
77 |             check_fail(libc::posix_spawn_file_actions_adddup2(
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn_file_actions_destroy` in crate `libc`
  --> src/fork_exec/spawn.rs:89:27
   |
89 |             let _ = libc::posix_spawn_file_actions_destroy(&mut self.0);
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `POSIX_SPAWN_SETSIGDEF` in crate `libc`
   --> src/fork_exec/spawn.rs:117:24
    |
117 |         flags |= libc::POSIX_SPAWN_SETSIGDEF;
    |                        ^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `POSIX_SPAWN_SETSIGMASK` in crate `libc`
   --> src/fork_exec/spawn.rs:118:24
    |
118 |         flags |= libc::POSIX_SPAWN_SETSIGMASK;
    |                        ^^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find value `POSIX_SPAWN_SETPGROUP` in crate `libc`
   --> src/fork_exec/spawn.rs:120:28
    |
120 |             flags |= libc::POSIX_SPAWN_SETPGROUP;
    |                            ^^^^^^^^^^^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn` in crate `libc`
   --> src/fork_exec/spawn.rs:157:19
    |
157 |             libc::posix_spawn(&mut pid, cmd, &self.actions.0, &self.attr.0, argv, envp)
    |                   ^^^^^^^^^^^ not found in `libc`

error[E0425]: cannot find function `posix_spawn` in crate `libc`
   --> src/fork_exec/spawn.rs:186:23
    |
186 |                 libc::posix_spawn(
    |                       ^^^^^^^^^^^ not found in `libc`

error[E0609]: no field `d_type` on type `&dirent`
   --> src/wutil/dir_iter.rs:291:50
    |
291 |         let typ = dirent_type_to_entry_type(dent.d_type);
    |                                                  ^^^^^^ unknown field
    |
    = note: available fields are: `d_ino`, `d_off`, `d_reclen`, `d_name`

error[E0599]: the method `and_then` exists for enum `Result<PosixSpawner, Errno>`, but its trait bounds were not satisfied
   --> src/exec.rs:851:48
    |
851 |         let pid = PosixSpawner::new(j, &dup2s).and_then(|mut spawner| {
    |                   -----------------------------^^^^^^^^ method cannot be called on `Result<PosixSpawner, Errno>` due to unsatisfied trait bounds
    |
   ::: src/fork_exec/spawn.rs:95:1
    |
95  | pub struct PosixSpawner {
    | ----------------------- doesn't satisfy `PosixSpawner: Sized`
    |
    = note: the following trait bounds were not satisfied:
            `{type error}: Sized`
            which is required by `PosixSpawner: Sized`

I.e.:

• No d_type - this is easy enough to work around
• No posix_spawn AT ALL, but posix_spawn exists in /usr/include/spawn.h
• No mkostemp, but it exists in /usr/include/stdlib.h
• No nix::sys::resource
• No libc::strftime

I'm going to say that these are going to need patches to the libc/nix crates instead of fish.

[Robert4S]

I'm going to say that these are going to need patches to the libc/nix crates instead of fish.

So, not something I can get merged then. All of the libc problems come from cfgs hiding stuff behind linux and linux-like target_os's. I'm assuming the only thing I can do then is to create externals specifically for fish for the illumos target.

[faho]

All of the libc problems come from cfgs hiding stuff behind linux and linux-like target_os

No. There are no cfgs on our side, and on the libc side e.g. posix_spawn is defined for a lot of osen - linux, bsds, macos, haiku, aix, ... I wouldn't call most of those "linux-like".

It's simply missing for "solarish". You need to add the equivalent of https://github.com/rust-lang/libc/blob/0f9f8c91adb0365c0d13b34ec27ac8019818cf1f/src/unix/bsd/freebsdlike/freebsd/mod.rs#L5183-L5190 (and the other posix_spawn stuff) to (presumably) https://github.com/rust-lang/libc/blob/main/src/unix/solarish/illumos.rs.

[faho]

Okay, these issues are entirely missing features in the libc/nix crates.

I'm going to close this as an issue there. If you try to get them fixed there and run into any trouble, get back to us and we'll see how much we can work around.

d_type would be easy (it's an optimization for globs), nix::sys::resource would probably require us to switch back to using libc there, strftime is basically impossible without disabling history --show-time, posix_spawn is a pretty big optimization and might be annoying to stub out, I don't know about mkostemp.

[faho]

Update on this: posix_spawn has been merged in libc (rust-lang/libc#4259) (added in version 0.2.170).

I can't find any relevant work in nix so far.