FML #3041

JDBetteridge · 2023-07-26T15:03:43Z

FML

firedrake/fml/form_manipulation_language.py

firedrake/fml/__init__.py

tommbendall

I have been thinking that we should rename the label name to name_label, so that we don't add an object called name to Firedrake's namespace, which could end up being very confusing!

firedrake/fml/form_manipulation_language.py

stale

* port FML changes from gusto * update docstring style * fix lint and docstring issues

Co-authored-by: tommbendall <[email protected]>

firedrake/fml/form_manipulation_language.py

firedrake/fml/replacement.py

firedrake/fml/form_manipulation_language.py

firedrake/fml/replacement.py

firedrake/fml/form_manipulation_language.py

… lambdas

JDBetteridge · 2023-10-23T17:05:24Z

For those with opinions, feel free to review new docstrings and typehints policy.

firedrake/fml/form_manipulation_language.py

dham previously requested changes Jul 26, 2023

View reviewed changes

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved

stephankramer reviewed Jul 26, 2023

View reviewed changes

firedrake/fml/__init__.py Outdated Show resolved Hide resolved

JDBetteridge force-pushed the JDBetteridge/fml branch from 0074ad8 to 4331d5c Compare August 11, 2023 11:36

JDBetteridge force-pushed the JDBetteridge/fml branch from 4331d5c to 55a76c1 Compare September 22, 2023 13:08

JDBetteridge marked this pull request as ready for review September 22, 2023 18:00

JDBetteridge requested a review from dham September 25, 2023 13:21

tommbendall previously requested changes Sep 25, 2023

View reviewed changes

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved

JDBetteridge force-pushed the JDBetteridge/fml branch from 8dc54df to 73b2307 Compare October 5, 2023 10:54

JDBetteridge and others added 5 commits October 9, 2023 21:49

Move FML from Gusto to Firedrake

92c0fa8

Bring across updates to FML in Gusto to the FML branch (#3055)

8dfdf33

* port FML changes from gusto * update docstring style * fix lint and docstring issues

Fix FML tests for complex

ba95a46

Fix FML docstrings

f2e4c3d

Apply suggestions from code review

844b4a0

Co-authored-by: tommbendall <[email protected]>

JDBetteridge force-pushed the JDBetteridge/fml branch from 73b2307 to 844b4a0 Compare October 9, 2023 20:50

dham requested changes Oct 11, 2023

View reviewed changes

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved

Remove RST roles from docstrings

4b90e35