Platform dependent irq assignment for the mmio device manager #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
previously approved these changes
Mar 12, 2019
alxiord
reviewed
Mar 12, 2019
Since the interval of allowed IRQ IDs for the device manager is x86_64 specific, it was moved in the layout for the x86_64 architecture. Signed-off-by: Diana Popa <[email protected]>
Signed-off-by: Diana Popa <[email protected]>
|
@aghecenco implemented suggested changes. Take a look. |
serban300
approved these changes
Mar 13, 2019
alxiord
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #757
Description of changes: The interrupts assignment (irq base, maximum irq) is platform dependent but up until now we would be hard coding those for x86_64 inside the mmio device manager. Refactored the code accordingly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.