added vsock definition in experimental yaml #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeaflorescu
force-pushed
the
vsock_yaml
branch
from
bbdd283 to
1b2c6eb
Compare
andreeaflorescu
force-pushed
the
vsock_yaml
branch
from
1b2c6eb to
bc4530f
Compare
alxiord
reviewed
May 9, 2019
andreeaflorescu
force-pushed
the
vsock_yaml
branch
from
bc4530f to
fccb452
Compare
|
@aghecenco Thanks for pointing me to the test. I updated it now, please take a look and let me know. |
dianpopa
reviewed
May 9, 2019
andreeaflorescu
force-pushed
the
vsock_yaml
branch
from
fccb452 to
53a5781
Compare
alxiord
previously approved these changes
May 9, 2019
dianpopa
previously approved these changes
May 9, 2019
Added firecracker-experimental.yaml in api_server/swagger. This file is a copy of firecracker.yaml with an additional definiton for the vsock API request. The point of this file is to be used by third-party projects (like Kata Containers) to automatically generate an API client that knows how to send requests to the Firecracker API. The definition currently lies in a different file and not in firecracker.yaml because vsock is consider an experimental feature. Once the production ready vsock is merged we will get rid of this experimental yaml. For tracking purposes, this is the issue regarding switching to vsock with UDS: firecracker-microvm#650 In the new proposed vsock implementation, the API request for configuring the vsock will also change. Fixes firecracker-microvm#1085 Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
vsock_yaml
branch
from
53a5781 to
e4e7f53
Compare
alxiord
approved these changes
May 9, 2019
dianpopa
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
Description of changes:
Added firecracker-experimental.yaml in api_server/swagger.
This file is a copy of firecracker.yaml with an additional definiton
for the vsock API request.
The point of this file is to be used by third-party projects (like
Kata Containers) to automatically generate an API client that knows
how to send requests to the Firecracker API. The definition currently
lies in a different file and not in firecracker.yaml because vsock
is consider an experimental feature. Once the production ready vsock
is merged we will get rid of this experimental yaml.
For tracking purposes, this is the issue regarding switching to
vsock with UDS:
#650
In the new proposed vsock implementation, the API request for
configuring the vsock will also change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.