npm list fallback, increase timeout to 60s #8702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Changes Requested [PR]
in [Cloud] Extensions + Functions
leoortizz
commented
Jun 3, 2025
| } catch (e) { | ||
| // fallback to reading the version directly from package.json if npm list times out | ||
| const packageJson = readJsonSync(join(cwd, name, "package.json"), { throws: false }); | ||
| return packageJson?.version ? { version: packageJson.version } : undefined; |
There was a problem hiding this comment.
if we choose to use this, we might want to mimic npm list json structure here. Currently all places calling this function are only using the version, so I only implemented the version for now
@alexastrum FWICT the failing tests are unrelated to these changes.
|
alexastrum
approved these changes
Jun 3, 2025
github-project-automation
bot
moved this from Changes Requested [PR]
to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the issue reported in #8689. The npm command timeout was increased to 60s due to how slow it runs in non-npm projects, notably with pnpm as reported in the issue.
Additionally, a fallback was added in case the timeout is reached, where the dependency version is read directly from its package.json within node_modules.
Scenarios Tested
deploy Next.js project with pnpm
Sample Commands
firebase deploy