Skip to content

Fix sessions e2e test #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix sessions e2e test #7029

wants to merge 2 commits into from

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jun 13, 2025

No description provided.

@gemini-code-assist Gemini Code Assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions GitHub Actions
Copy link
Contributor

Firebase AI Mock Responses Check ⚠️

A newer major version of the mock responses for Firebase AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v14.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

Test Results

 1 058 files  + 34   1 058 suites  +34   35m 51s ⏱️ + 1m 12s
 5 985 tests +188   5 962 ✅ +188  22 💤 ±0  1 ❌ ±0 
12 033 runs  +376  11 988 ✅ +376  44 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit ba144e9. ± Comparison against base commit f735209.

♻️ This comment has been updated with latest results.

@mrober mrober requested a review from themiswang June 13, 2025 13:49
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f735209) and merge commit (0d9daeb).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oXXbrtwjoX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (f735209) to 50.21% (0d9daeb) by +0.04%.

    FilenameBase (f735209)Merge (0d9daeb)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-messaging

    Overall coverage changed from 84.02% (f735209) to 84.13% (0d9daeb) by +0.11%.

    FilenameBase (f735209)Merge (0d9daeb)Diff
    Metadata.java36.51%41.27%+4.76%

  • firebase-ml-modeldownloader

    Overall coverage changed from ? (f735209) to 82.11% (0d9daeb) by ?.

    36 individual files with coverage change

    FilenameBase (f735209)Merge (0d9daeb)Diff
    AutoFirebaseMlLogEventEncoder.java?100.00%?
    AutoValue_FirebaseMlLogEvent.java?56.60%?
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java?58.33%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java?56.96%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java?60.00%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java?56.25%?
    AutoValue_FirebaseMlLogEvent_SystemInfo.java?54.93%?
    CustomModel.java?72.13%?
    CustomModelDownloadConditions.java?88.46%?
    CustomModelDownloadService.java?79.89%?
    CustomModelDownloadService_Factory.java?0.00%?
    CustomModel_Factory.java?0.00%?
    CustomModel_Factory_Impl.java?0.00%?
    DaggerModelDownloaderComponent.java?100.00%?
    DataTransportMlEventSender.java?100.00%?
    DataTransportMlEventSender_Factory.java?0.00%?
    DownloadType.java?100.00%?
    FirebaseMlException.java?100.00%?
    FirebaseMlLogEvent.java?97.92%?
    FirebaseMlLogger.java?88.89%?
    FirebaseMlLogger_Factory.java?0.00%?
    FirebaseModelDownloader.java?84.66%?
    FirebaseModelDownloaderRegistrar.java?100.00%?
    FirebaseModelDownloader_Factory.java?0.00%?
    ModelDownloader.kt?91.67%?
    ModelDownloaderComponent.java?25.00%?
    ModelDownloaderComponent_MainModule_AppPackageNameFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_AppVersionCodeFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_FirebaseOptionsFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_PersistenceKeyFactory.java?0.00%?
    ModelFileDownloadService.java?88.46%?
    ModelFileDownloadService_Factory.java?0.00%?
    ModelFileManager.java?82.28%?
    ModelFileManager_Factory.java?0.00%?
    SharedPreferencesUtil.java?97.26%?
    SharedPreferencesUtil_Factory.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6mXuqlrNOz.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (122,589 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wEjtbskTNl/index.html

@mrober mrober force-pushed the mrober/sessionsE2e branch from 9675837 to f788483 Compare June 13, 2025 15:01
@mrober mrober requested a review from davidmotson June 13, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themiswang themiswang themiswang approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @themiswang