Skip to content

Update config for GSI v7 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2024
Merged

Update config for GSI v7 #1200

merged 1 commit into from
Aug 15, 2024

Conversation

paulb777
Copy link
Member

Fix #1198

The GSI config needs to be initialized with the clientID for GSI 7+

@paulb777 paulb777 requested a review from morganchen12 August 15, 2024 00:06
@paulb777 paulb777 mentioned this pull request Aug 14, 2024
Closed
@paulb777 paulb777 requested a review from ncooke3 August 15, 2024 00:22
@ncooke3
Copy link
Member

ncooke3 commented Aug 15, 2024

Will this fix part of #1199?:

Sign in with Google:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'No active configuration.  Make sure GIDClientID is set in Info.plist.'
*** First throw call stack:
(0x195758f20 0x18d6532b8 0x1958576dc 0x101e33b2c 0x101e32694 0x101cac8b4 0x101e1a3e0 0x101e20efc 0x197d524f8 0x197d523d0 0x197d52220 0x198269200 0x19826aa14 0x1979e1ce0 0x197adcb04 0x197c9374c 0x197c92a10 0x197b13924 0x197b15118 0x197b1de10 0x197a10740 0x197a0e660 0x197a0e2a4 0x197a0f148 0x19572b834 0x19572b7c8 0x195729298 0x195728484 0x195727cd8 0x1da1751a8 0x197d61ae8 0x197e15d98 0x19991c294 0x1998c8860 0x1998d461c 0x10178b33c 0x10178b658 0x1b8eff154)
libc++abi: terminating due to uncaught exception of type NSException

@paulb777
Copy link
Member Author

Yes, the Info.plist change is not needed with Firebase, since the clientID comes from the GoogleService-Info.plist

@paulb777 paulb777 merged commit dba3881 into main Aug 15, 2024
8 checks passed
@paulb777 paulb777 deleted the pb-gsi-config branch August 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FUIAuthDelegate methods not called in v.14
2 participants
@paulb777 @ncooke3