-
-
Notifications
You must be signed in to change notification settings - Fork 538
Add option to pass in a custom handlebars template to generate the service files #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request fixes 4 alerts when merging b24a97c into abab307 - view on LGTM.com fixed alerts:
|
Can this be moved out of draft? |
If there is interest by @ferdikoomen to eventually merge it, I might put in the time to clean up the PR... but of course feel free to cherry-pick commits etc. |
Dear @ferdikoomen, @mb21 and @josh-hemphill, I hope you're all doing well. I noticed a shared need for custom Handlebar templates, and I found myself in a similar situation. However, I required additional flexibility for my specific use case. In response, I've submitted a "competing" Pull Request, presenting the simplest solution I could come up with that allows customization of all templates and partials across the system. I would sincerely appreciate your insights and feedback on these changes, in case there's anything I can do to enhance this implementation. Thank you in advance for taking the time to review and provide your input. |
One thing I discovered was that when some of the current templates get called, they're not provided enough properties of the context to be useful for much customisation, I had to add the additional context to the template calls in to get any of my stuff working; it doesn't seem to hurt anything to have extra context provided to the default templates. |
@josh-hemphill I agree that enhancing the context passed to templates is good for customization. I do believe implementing this in a separate pull request would be a better approach to keep Issues/PRs organized and easy to understand; facilitate unit testing, ease code review and minimize risks. |
Add option to pass in custom handlebars templates ferdikoomen#1268 ferdikoomen#1995
Adds the
--serviceTemplate
option, which can be used to pass in a custom handlebars template to generate the service files.This is a rough draft PR with what we're currently using, if you're interested in merging this, can be refined.
Solves #1191, #703 (comment) and potentially a big number of other customization requests.
We're currently using this with this template: