Skip to content

Avoid calling substring to remove a comma. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2017
Merged

Avoid calling substring to remove a comma. #38

merged 2 commits into from
Jul 5, 2017

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jul 5, 2017

Fixes #15

@mcollina mcollina requested a review from delvedor July 5, 2017 16:24
delvedor
delvedor approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!!

@mcollina mcollina merged commit 455bc28 into master Jul 5, 2017
@mcollina mcollina deleted the fix-array branch July 5, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @delvedor