Skip to content

Update to Fastify v4 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2022
Merged

Update to Fastify v4 #9

merged 4 commits into from
May 23, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented May 18, 2022

No description provided.

@mcollina
Copy link
Member

Are we sure we want to support both with the same major? Wouldn't be simpler to support only one?

@kibertoad
Copy link
Member

I would vote in favour of upping major and dropping support for v3

README.md Outdated
@@ -8,9 +8,10 @@ This package is responsible for compiling the application's `response` JSON sche

## Versions

| `@fastify/fast-json-stringify-compiler` | `fast-json-stringify` | Default in `fastify` |
| `@fastify/fast-json-stringify-compiler` | `fast-json-stringify` | Supported `fastify` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is extra space intentional?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina changed the title test: add fastify v3 and v4 tests Update to Fastify v4 May 20, 2022
@mcollina mcollina merged commit e0a6fd0 into main May 23, 2022
@Fdawgs Fdawgs deleted the fastify-v4 branch August 10, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants