-
-
Notifications
You must be signed in to change notification settings - Fork 5
nodenext compatibility, correct typings #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI seems failing |
The original typings are wrong. Currently checking |
Ok, fixed the typings. They were from the beginning wrong. So I assume, nobody uses fast-json-stringify-compiler in a typescript environment. I had to change the purpose of some typings, which means, that it could be a breaking change. But on the other hand, as mentioned before, nobody complained about the fact that the typings were wrong, so probably nobody will complain anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Let's wait for @Eomm before landing this one. |
I agree. |
Part of Migration of the infamous triplet to next level, Nodenext support
Checklist
npm run test
andnpm run benchmark
and the Code of conduct