Skip to content

Wrong SSR diff warning due to non lowercase attributes #10672

Closed
@paradoxxxzero

Description

@paradoxxxzero

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
I got this warning: Warning: Extra attributes from the server: preserveAspectRatio,viewBox during client side hydratation when my react tree contains mixed case attributes such as these svg ones.

What is the expected behavior?

No warnings because there are no difference between server and client attributes.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React 16.0.0-rc.2
This worked on 15.*

This seems to happen because the attribute name is put to lowercase here:

var name = attributes[i].name.toLowerCase();

but not in the set here:
extraAttributeNames.add(attributes[i].name);

As the set removal is done with the lowercased attribute:
extraAttributeNames.delete(propKey.toLowerCase());

it stays in the extraAttributeNames set and I got wrongly the previous warning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions