-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Add option to provide custom ssl certificates during development #5845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9c88c30
Add option to provide custom SSL certificates when using HTTPS
alexbrazier 3d7388c
Update documentation with custom HTTPS certs
alexbrazier ab6b112
Improve certificate validation and move to its own file
alexbrazier 5de0e3e
Update https in development docs
alexbrazier 3480786
Add custom cert example to docs
alexbrazier ae89550
Rename https file and update error message
alexbrazier 3ec78d5
Include original error message when custom ssl cert is invalid
alexbrazier 81dbb8e
Add chalk to react-scripts dependencies
alexbrazier 3671f39
Bump docs version to say that the new config will be available in 3.2.0
alexbrazier ac784e7
Merge remote-tracking branch 'origin/master' into feature/custom-ssl
alexbrazier 772150b
Merge branch 'master' into feature/custom-ssl
alexbrazier 6d4d9ea
Remove chalk dependency
alexbrazier 83486e3
Merge remote-tracking branch 'facebook/master' into feature/custom-ssl
alexbrazier a5ab56d
Update custom ssl version to 3.4.0 in docs
alexbrazier b029ef3
Remove version from custom ssl certificate docs
alexbrazier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
// @remove-on-eject-begin | ||
/** | ||
* Copyright (c) 2015-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
// @remove-on-eject-end | ||
'use strict'; | ||
|
||
const fs = require('fs'); | ||
const path = require('path'); | ||
const crypto = require('crypto'); | ||
const chalk = require('react-dev-utils/chalk'); | ||
const paths = require('./paths'); | ||
|
||
// Ensure the certificate and key provided are valid and if not | ||
// throw an easy to debug error | ||
function validateKeyAndCerts({ cert, key, keyFile, crtFile }) { | ||
let encrypted; | ||
try { | ||
// publicEncrypt will throw an error with an invalid cert | ||
encrypted = crypto.publicEncrypt(cert, Buffer.from('test')); | ||
} catch (err) { | ||
throw new Error( | ||
`The certificate "${chalk.yellow(crtFile)}" is invalid.\n${err.message}` | ||
); | ||
} | ||
|
||
try { | ||
// privateDecrypt will throw an error with an invalid key | ||
crypto.privateDecrypt(key, encrypted); | ||
} catch (err) { | ||
throw new Error( | ||
`The certificate key "${chalk.yellow(keyFile)}" is invalid.\n${ | ||
err.message | ||
}` | ||
); | ||
} | ||
} | ||
|
||
// Read file and throw an error if it doesn't exist | ||
function readEnvFile(file, type) { | ||
if (!fs.existsSync(file)) { | ||
throw new Error( | ||
`You specified ${chalk.cyan( | ||
type | ||
)} in your env, but the file "${chalk.yellow(file)}" can't be found.` | ||
); | ||
} | ||
return fs.readFileSync(file); | ||
} | ||
|
||
// Get the https config | ||
// Return cert files if provided in env, otherwise just true or false | ||
function getHttpsConfig() { | ||
const { SSL_CRT_FILE, SSL_KEY_FILE, HTTPS } = process.env; | ||
const isHttps = HTTPS === 'true'; | ||
|
||
if (isHttps && SSL_CRT_FILE && SSL_KEY_FILE) { | ||
const crtFile = path.resolve(paths.appPath, SSL_CRT_FILE); | ||
const keyFile = path.resolve(paths.appPath, SSL_KEY_FILE); | ||
const config = { | ||
cert: readEnvFile(crtFile, 'SSL_CRT_FILE'), | ||
key: readEnvFile(keyFile, 'SSL_KEY_FILE'), | ||
}; | ||
|
||
validateKeyAndCerts({ ...config, keyFile, crtFile }); | ||
return config; | ||
} | ||
return isHttps; | ||
} | ||
|
||
module.exports = getHttpsConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.