Skip to content

Add allowESModules option to babel-preset-react-app #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Add allowESModules option to babel-preset-react-app #5487

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec0a9cf
Add allowESModules option to babel-preset-react-app
Oct 19, 2018
f659623
changes after feedback
Pajn Nov 19, 2018
063a817
Apply suggestions from code review
Timer Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/babel-preset-react-app/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ module.exports = function(api, opts, env) {
var isEnvProduction = env === 'production';
var isEnvTest = env === 'test';

var allowESModules = validateBoolOption('allowESModules', opts.allowESModules, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this default to isEnvDevelopment || isEnvProduction and use the existing name.

Suggested change
var allowESModules = validateBoolOption('allowESModules', opts.allowESModules, true);
var useESModules = validateBoolOption('useESModules', opts.useESModules, isEnvDevelopment || isEnvProduction);

var isFlowEnabled = validateBoolOption('flow', opts.flow, true);
var areHelpersEnabled = validateBoolOption('helpers', opts.helpers, true);
var useAbsoluteRuntime = validateBoolOption(
Expand Down Expand Up @@ -140,7 +141,7 @@ module.exports = function(api, opts, env) {
// https://babeljs.io/docs/en/babel-plugin-transform-runtime#useesmodules
// We should turn this on once the lowest version of Node LTS
// supports ES Modules.
useESModules: isEnvDevelopment || isEnvProduction,
useESModules: allowESModules ? isEnvDevelopment || isEnvProduction : false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequently, this becomes simpler (or use the shorthand syntax):

Suggested change
useESModules: allowESModules ? isEnvDevelopment || isEnvProduction : false,
useESModules: useESModules,

// Undocumented option that lets us encapsulate our runtime, ensuring
// the correct version is used
// https://github.com/babel/babel/blob/090c364a90fe73d36a30707fc612ce037bdbbb24/packages/babel-plugin-transform-runtime/src/index.js#L35-L42
Expand Down