--scripts-version should accept tags

[gaearon]

We should change global CLI to accept tag there. Right now it accepts package name. Maybe we could have two separate flags?

[vjeux]

If you do --scripts-version @latest it should work, doesn't it?

[gaearon]

Maybe (I didn't thought about using this syntax). I expected that I can replace version with tag and it will still work, but it doesn't (have to add @?). I think people used to npm want to treat them as interchangeable.

[vjeux]

Actually I was wrong.

Logic is here: https://github.com/facebookincubator/create-react-app/blob/master/global-cli/index.js#L133

It checks if it is semver valid, which doesn't work with arbitrary tag names.

[fson]

At the moment, if the value passed to --scripts-version is not a valid semver string, it's passed to npm install as is, so this already works:

create-react-app --scripts-version facebookincubator/create-react-app#v0.2.0 my-app

You can install from a tag, a tarball, or even a feature branch from a forked repo:

create-react-app --scripts-version fson/create-react-app#syntax-async-functions my-app

[gaearon]

This would be a different setup though. We do some stuff as prepublish step (bundle dependencies). So we want it to work with npm tag, not GH tag.

[fson]

@gaearon Ah, sorry somehow I assumed this was about git tags 😄

[gaearon]

Don’t really care too much about it.