Add Clippy checks to the travis script #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Я так понимаю, это значит "clippy, молчи, тут нужно передавать по значению":
[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))]
Можно ли это сделать на уровне файла, если там одни JNI функции? Или так ты можешь потерять полезные сообщения clippy?
|
Right, it is needed to disable some checks and you give me even a better idea: this warning can be disabled for the whole project and enabled only for the |
|
Finally ready for review. 😅 |
|
the less annotations, the better :-) |
dmitry-timofeev
approved these changes
Jun 23, 2017
|
Unfortunately, yes. Clippy uses unstable language features that are available only in the nightly builds. |
diminio1
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.