Skip to content

feat: Allow users to configure new/legacy I2C driver for SCCB hardware #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

finger563
Copy link

@finger563 finger563 commented May 20, 2025

Description

Add Kconfig option to select legacy or new I2C driver for SCCB communications.

Related

Fixes #741

Testing

I have run this locally as part of changes on my camera-streamer project using the fork esp32-camera.

esp-cpp/camera-streamer#10


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@AxelLin
Copy link

AxelLin commented May 21, 2025

Because SCCB_HARDWARE_I2C_DRIVER_NEW is only available for IDF-5.4+,
to avoid breaking existing application,
I think the SCCB_HARDWARE_I2C_DRIVER_SELECTION should be default to SCCB_HARDWARE_I2C_DRIVER_LEGACY.

@finger563
Copy link
Author

Because SCCB_HARDWARE_I2C_DRIVER_NEW is only available for IDF-5.4+,
to avoid breaking existing application,
I think the SCCB_HARDWARE_I2C_DRIVER_SELECTION should be default to SCCB_HARDWARE_I2C_DRIVER_LEGACY.

@AxelLin it actually gets overridden in cmakelists if esp idf is < 5.4

@AxelLin
Copy link

AxelLin commented May 21, 2025

@AxelLin it actually gets overridden in cmakelists if esp idf is < 5.4

Ok, there is no breakage with older IDF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legacy/new i2c driver conflict issue
2 participants