Skip to content

Set SPI_HAS_TRANSACTION to 1 #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2019
Merged

Set SPI_HAS_TRANSACTION to 1 #6591

merged 2 commits into from
Oct 5, 2019

Conversation

Lauszus
Copy link
Contributor

@Lauszus Lauszus commented Oct 3, 2019

See #2639

@Lauszus Lauszus mentioned this pull request Oct 3, 2019
Closed
earlephilhower
earlephilhower approved these changes Oct 4, 2019
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just checked the AVR definition and it does set it to 1, not just define it.

https://github.com/arduino/ArduinoCore-avr/blob/master/libraries/SPI/src/SPI.h

@earlephilhower earlephilhower added this to the 2.6.0 milestone Oct 4, 2019
@earlephilhower earlephilhower merged commit 5d20137 into esp8266:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Lauszus @earlephilhower