Add HardwareSerial::updateBaudRate(unsigned long baud) #6494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… begin was called
Jeroen88
changed the title
|
@d-a-v or @earlephilhower, any chance this gets merged soon? :) |
earlephilhower
requested changes
Sep 15, 2019
| @@ -133,8 +142,8 @@ unsigned long HardwareSerial::detectBaudrate(time_t timeoutMillis) | |||
| return detectedBaudrate; | |||
| } | |||
|
|
|||
| size_t HardwareSerial::readBytes(char* buffer, size_t size) | |||
| { | |||
| size_t HardwareSerial::readBytes(char* buffer, size_t size) | |||
There was a problem hiding this comment.
Is this a linefeed change here? I think this whole file is DOS \r\n formatted, but your patch only has \UNIX n. For now, could you make sure you match the linefeeds of the rest of the file (yes, I hate DOS linefeeds, too, but we need to be consistent in any particular file).
There was a problem hiding this comment.
I really do not know. I did not touch these lines. Could you please check it?
There was a problem hiding this comment.
It is indeed a crlf change.
And after checking, this PR restores consistency which is not here in current master.
(The Allman process shall have a try-again session)
d-a-v
approved these changes
Sep 16, 2019
earlephilhower
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HardwareSerial::updateBaudRate(unsigned long baud) to change the baudrate after ::begin() was called.