Skip to content

Fix SSID reporting for 32-char SSIDs #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Conversation

earlephilhower
Copy link
Collaborator

@earlephilhower earlephilhower commented Mar 17, 2019

Fixes #5853

Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@earlephilhower thanks, you beat me to it 😄

@devyte devyte merged commit 68bcc41 into esp8266:master Mar 18, 2019
@DarkiStar
Copy link

Hello,

are you sure
memcpy(ssid_copy, it->ssid, sizeof(it->ssid));
is the best solution?

memcpy(ssid_copy, it->ssid, sizeof(ssid_copy));
looks more safe to me.

regards

@earlephilhower
Copy link
Collaborator Author

@DarkiStar, if the size of the SSID field increases beyond 33 then you're correct. I think realistically, though, either one is fine. Wireless BGN SSIDs are not going to increase, since if they did then I'd bet most devices out there would go pop...

@earlephilhower earlephilhower deleted the wifi32b branch March 19, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants