Fix minor warning w/Ubuntu18.04 in host test build #5829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC reports the following warning about ignoring the return value of write() (to the console/UART in this instance). common/MockUART.cpp: In function ‘void uart_do_write_char(int, char)’: common/MockUART.cpp:67:8: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result] write(uart_nr + 1, &c, 1); ~~~~~^~~~~~~~~~~~~~~~~~~~ Add a simple warning printout to STDERR which may not be the same as the UART stream and could succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC reports the following warning about ignoring the return value of
write() (to the console/UART in this instance).
Add a simple warning printout to STDERR which may not be the same as the
UART stream and could succeed.