Resolve updater size check bug #4550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will begin() report an error with this fix? |
|
Yes, the underflow fix will trigger the proper size error reporting logic in line 98-100 |
|
Thanks for finding this :) |
bryceschober
pushed a commit
to bryceschober/Arduino
that referenced
this pull request
Apr 5, 2018
(cherry picked from commit 2d39bcb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentially tried to OTA a 2MB+ file, and found the Updater.begin() actually did not report any error.
Turned out there is an arithmetic underflow on an unsigned type.