Skip to content

Added support for 40MHz crystal frequency #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

jeremypoulter
Copy link

This is needed for some ESP8266 modules that, for example the module in this SmartPlug, that have a 40Mhz crystal rather than the 'normal' 26MHz.

@torntrousers
Copy link
Contributor

Hi Jeremy, that SmartPlug looks interesting but I can't find much on it, do you have any links to more about it - photos of inside or info about re-programing it etc?

@jeremypoulter
Copy link
Author

Some info on the module can be found here; https://detail.1688.com/offer/45107082796.html and there is some discussion on it in this forum; https://www.letscontrolit.com/forum/viewtopic.php?t=2159 however I am still working on the full documentation of my efforts with this plug.

@codecov-io
Copy link

codecov-io commented Mar 13, 2017

Codecov Report

Merging #3025 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3025   +/-   ##
=======================================
  Coverage   27.82%   27.82%           
=======================================
  Files          20       20           
  Lines        3626     3626           
  Branches      656      656           
=======================================
  Hits         1009     1009           
  Misses       2441     2441           
  Partials      176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01638f...346dec9. Read the comment docs.

@gvJaime
Copy link

gvJaime commented Apr 2, 2017

I've had issues #3004 and #3094 with the Arduino UNO WiFi, because of this little 40MHz crystal detail.

It would be great that this pull request gets merged because right now I have to modify the framework by hand to make it work. It would be easier with this simple flag.

@jeremypoulter
Copy link
Author

Somewhat frustratingly this change was added (not quite as cleanly IMHO) by #3121 so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants