Async ota #1056
Merged
Async ota #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull master
pull master
still up to the user to call ArduinoOTA.handle() to start the upload
| @@ -70,7 +84,12 @@ void ArduinoOTAClass::begin() { | |||
| _port = 8266; | |||
| } | |||
|
|
|||
| _udp_ota.begin(_port); | |||
| _udp_ota = new UdpContext; | |||
There was a problem hiding this comment.
You have to check that _udp_ota is nullptr before creating another one. If it isn't, unref it first. This could happen if someone calls begin() twice for some reason.
Also destructor is missing... Add it along with if (_udp_ota) _udp_ota->unref();. I know that ArduinoOTA is a static object now, but it's omission makes any c++ programmer weep :)
There was a problem hiding this comment.
there is a destructor :) it's empty though
There was a problem hiding this comment.
Oh right. Lost it among other one-liners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still up to the user to call ArduinoOTA.handle() to start the upload