Skip to content

Generic ESP8285 Module please add GPIO16 to LED menu #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gknauf opened this issue Feb 24, 2019 · 0 comments · Fixed by #6343
Closed

Generic ESP8285 Module please add GPIO16 to LED menu #5817

gknauf opened this issue Feb 24, 2019 · 0 comments · Fixed by #6343

Comments

@gknauf
Copy link

gknauf commented Feb 24, 2019

I have an ESP8285 board which has its onboard LED connected to GPIO16, but the "Generic ESP8285 Module" menu allows only 0-15 setting for "Builtin Led". Please add an entry for GPIO16 setting:

--- boards.txt.orig	2019-02-24 14:02:59.600425500 +0100
+++ boards.txt	2019-02-24 14:04:49.654671800 +0100
@@ -620,6 +620,8 @@
 esp8285.menu.led.14.build.led=-DLED_BUILTIN=14
 esp8285.menu.led.15=15
 esp8285.menu.led.15.build.led=-DLED_BUILTIN=15
+esp8285.menu.led.16=16
+esp8285.menu.led.16.build.led=-DLED_BUILTIN=16
 esp8285.menu.ip.lm2f=v2 Lower Memory
 esp8285.menu.ip.lm2f.build.lwip_include=lwip2/include
 esp8285.menu.ip.lm2f.build.lwip_lib=-llwip2-536-feat

thanks!
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Jul 25, 2019
@earlephilhower
Allow use of LED16 for generic boards
f098bf1 
Generic boards can have their LEDs on pins 0...16 inclusive, so ensure
that the range we generate in boards.txt is inclusive.

Fixes esp8266#5817
@earlephilhower earlephilhower mentioned this issue Jul 25, 2019
Merged
d-a-v pushed a commit to earlephilhower/Arduino that referenced this issue Jul 25, 2019
@earlephilhower @d-a-v
Allow use of LED16 for generic boards (esp8266#6343)
34077c0 
Generic boards can have their LEDs on pins 0...16 inclusive, so ensure
that the range we generate in boards.txt is inclusive.

Fixes esp8266#5817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow use of LED16 for generic boards earlephilhower/Arduino
1 participant
@gknauf