Skip to content

Pointer arithmetic error in spiffs_hal_read #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelucid opened this issue Mar 20, 2017 · 0 comments
Closed

Pointer arithmetic error in spiffs_hal_read #3065

joelucid opened this issue Mar 20, 2017 · 0 comments

Comments

@joelucid
Copy link
Contributor

joelucid commented Mar 20, 2017

spiffs_hal_read has a pointer arithmetic error that leads to crashes when reading from non-aligned addresses. Here's the patch:

diff --git a/cores/esp8266/spiffs_hal.cpp b/cores/esp8266/spiffs_hal.cpp
index 7f3245c..567b064 100644
--- a/cores/esp8266/spiffs_hal.cpp
+++ b/cores/esp8266/spiffs_hal.cpp
@@ -60,7 +60,7 @@ int32_t spiffs_hal_read(uint32_t addr, uint32_t size, uint8_t *dst) {
                 __LINE__, addr, size, alignedBegin, alignedEnd);
             return SPIFFS_ERR_INTERNAL;
         }
-        memcpy(dst, &tmp + 4 - nb, nb);
+        memcpy(dst, (uint8_t*)&tmp + 4 - nb, nb);
     }
 
     if (alignedEnd != alignedBegin) { 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants