BUILTIN_LED should be LED_BUILTIN

[SukkoPera]

Arduino's macro that holds the number of the built-in led in boards is LED_BUILTIN. For some reason, this core uses BUILTIN_LED, leading to unportable code.

See: https://www.arduino.cc/en/Reference/Constants

[tuxedo0801]

I also stumbled on this.

Is there a reason why the macro does not match?

[tuxedo0801]

Added a PR for this: #1556

[SukkoPera]

Well done :)

[tuxedo0801]

@SukkoPera
Please close, PR #1556 is been merged.

[SukkoPera]

Ok, thanks. I'm not really for keeping both macros, but fair enough.