Skip to content

Add CI #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Add CI #5

merged 4 commits into from
Apr 26, 2023

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Apr 26, 2023

This adds CI.

I tried something new here: Using a justfile to run the actual checks and use as-little-as-possible of GitHub Actions

  • good: this makes it really easy to do the same checks locally (just use just)
  • downside: it's harder to see at a glance what exactly failed
  • downside: if the job fails, rerunning means rerunning everything

I'd like to experiment with this a bit since the first point is really something I'd like to have - maybe there are even solutions for the other two points

@bjoernQ bjoernQ marked this pull request as ready for review April 26, 2023 12:07
@bjoernQ bjoernQ requested a review from jessebraham April 26, 2023 12:07
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about just personally so can't comment on the justfile. CI config looks fine otherwise though.

@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Apr 26, 2023

I don't know anything about just personally so can't comment on the justfile. CI config looks fine otherwise though.

It's also the first time I used it but I've seen it used for other Rust projects in CI and I wanted to give it a try

Thanks for the review!

@bjoernQ bjoernQ merged commit f4f64f5 into main Apr 26, 2023
@bjoernQ bjoernQ deleted the add-ci branch April 26, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants