Skip to content

refactor: cleanup main code #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

refactor: cleanup main code #3

merged 1 commit into from
Nov 6, 2023

Conversation

finger563
Copy link
Contributor

Description

  • Updated espp submodule to have latest version with new peripheral apis and its own gt911 and tt21100 components
  • Removed gt911 and tt21100 components from this repo
  • Cleaned up main code to 1) use espp::I2c for cleaner init, 2) move hardware specific config into individual header files (wrover_kit.hpp, box.hpp, tdeck.hpp), and 3) use new peripheral api for espp::Gt911 and espp::Tt21100

Motivation and Context

Cleans up the main code and uses upstream components instead of local components. Also refactors platform specific configuration code into separate header files to enable easier porting to other platforms.

How has this been tested?

Building and running on the LilyGo T-Deck

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2023-11-06 at 08 49 27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated espp submodule to have latest version with new peripheral apis and its own gt911 and tt21100 components
* Removed gt911 and tt21100 components from this repo
* Cleaned up main code to 1) use espp::I2c for cleaner init, 2) move hardware specific config into individual header files (wrover_kit.hpp, box.hpp, tdeck.hpp), and 3) use new peripheral api for espp::Gt911 and espp::Tt21100
@finger563 finger563 merged commit bd0d3fa into main Nov 6, 2023
@finger563 finger563 deleted the feature/espp-update branch November 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant