Skip to content

feat(logger): optional rate limiting and additional Verbosity::NONE level #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jun 2, 2023

Description

  • Adds new APIs to the logger class to support rate limited output (only for calls with the new suffix _rate_limited).
  • Adds NONE logger verbosity to fully disable log output if desired

Motivation and Context

#60 Running quick control loops that require debugging make logging challenging since they run / log faster than the log can print. Enabling those logs to be rate limited (without affecting other logs) helps develop and debug those systems.

How has this been tested?

Running the updated example.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2023-06-02 at 12 01 28

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added enhancement New feature or request logger labels Jun 2, 2023
@finger563 finger563 changed the title feat(logger): allow rate limiting for logger feat(logger): optional rate limiting and additional Verbosity::NONE level Jun 2, 2023
@finger563 finger563 merged commit 81bfda0 into main Jun 2, 2023
@finger563 finger563 deleted the feature/logger-rate-limit branch June 2, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant