build the container while linting/testing #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwhitchcox
force-pushed
the
pr/two-stage-deploy
branch
from
c703309 to
5c849d5
Compare
|
Thank you! And thank you for creating the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this shaves a couple minutes off deployment time by building the container while the linting/typechecking/testing processes are running and using that container for deployment. It's the little things 🤷🏻♂️
Test Plan
I have tested with my own epic-stack derived app
Checklist
^ I don't think these are required, as the github actions deployment is not referenced in the docs, but correct me if I'm wrong!
Screenshots