Skip to content

Fix CI test #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Fix CI test #162

merged 5 commits into from
Apr 20, 2022

Conversation

jcs090218
Copy link
Contributor

I have recently created a tool named Eask. It's similar to Cask, but it has a better cross-platform capability. It tests your package/configuration in a much more consistent way.

This patch does the following:

  1. Replace Cask with Eask
  2. Add test for Emacs 28.1
  3. build.yml now has only one job (merged unix + windows)
  4. Fix test in windows-latest

@jcs090218 jcs090218 changed the title Improve CI test Fix CI test Apr 15, 2022
@jcs090218
Copy link
Contributor Author

@josteink Can you take a look at this PR as well? Only when you have time! :)

Copy link
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the phone so can't do full review now. I'll check back later.

@jcs090218
Copy link
Contributor Author

You can checkout my branch and see the full implementation https://github.com/jcs-PR/typescript.el/tree/ci. Or we can wait until you can use your PC. ;)

@josteink
Copy link
Member

Let’s get this merged then 🙂

@josteink josteink merged commit 694a168 into emacs-typescript:master Apr 20, 2022
@jcs090218 jcs090218 deleted the ci branch April 20, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants