Rework customization to use lsp-mode's functionality #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
defcustom
variables for settings, matching the vscodeextension for all the language server settings.
lsp-mode
's support for custom settings to handle sending them tothe server.
This lets users persistently configure their server settings using
normal Emacs setting customization.
This will probably break people, so should maybe be a major version
bump.
Fixes #69, #75, #78; supersedes the (excellent) #74 and #76.
Notes:
starting the server. We don't try and get prebuilt binaries, so I
thought it was simplest to stick to command-and-arguments.
avoid references to
hie
. This PR will already break basically everyone, soI thought I might as well do that too.
didChangeConfiguration
notification when called.
lsp-mode
does not currently do this whenyou change variables, which is annoying. My inclination is to let them
fix it in the name of simplicity, but if anyone really hates not being
able to change the formatter without restarting the server I can try and
hack something together.