Fail S3 deploy when incompatible filename detected

[ramshorst]

Update: changing this issue to be one to guard against and fail the deploy when incompatible filename detected for S3 deploy. Should provide good feedback to the user of what's going on. Ideally, lookup and guard against this before the deploy processes starts, if possible.

original desc:

Having a é in an image file name stops the export process and it takes quitte some time to figure out what is wrong reading the export log. I would be great it these would still work!
Have a great day!

[leonstafford]

Thanks @ramshorst!

Will either guard against this or see if there is a solution to allow them. Official AWS SDK may handle it better. I'd like to avoid including whole AWS SDK for PHP in the plugin (again) if possible, but we'll see what makes most sense

[leonstafford]

note: this is regarding deployment to S3, unsure of others

[leonstafford]

@ramshorst - this should be fine now in V7, which has an improved S3 add-on ready for testing, too: https://github.com/WP2Static/wp2static/releases/tag/7.0-alpha-003

[leonstafford]

in this repo (v6) , S3 API based deploy still fails on this issue, but exporting to ZIP and then using AWS CLI tool to sync works fine, with unicode/multibyte chars.

[leonstafford]

switching to same AWS S3 PHP SDK as in https://github.com/WP2Static/wp2static may help with this, else fallback is to use CLI tool

[ramshorst]

I can confirm that on 6.6.7 this error still exists. To reproduce it put an image containing an é in the URL in the export. I agree this is a bad idea to start with. The problem in my experience is mostly that it takes some time to debug since the log file can not be loaded.

[leonstafford]

Thanks for testing so quickly, @ramshorst!

Yeah, it's a bit frustrating and their docs are not too enlightening, stating something like "unicode characters in keys are supported, but some characters are bad, especially these ones, like @, .... Right now, code is just escaping the @ symbol and I avoided adding in the other handful they specifically say to watch out for, but may need to deep dive into that. I don't it included the é unless it was mentioned in an ascii range or such.

I tried today with some Cyrillic and it failed horribly via UI S3 deployment, but had no troubles with Japanese and Cyrillic yesterday, when deploying to S3 or Netlify via ZIP.

Well, I had a day of troubles and doing silly things, but got there in the end: #58

[leonstafford]

here's a sample from yesterday on Netlify, same tested on S3 was fine via CLI sync: https://hardcore-bhabha-57bf62.netlify.app/, including special chars in the img filename

[leonstafford]

@ramshorst this had helped some people in the past and may be worth checking out if it will save you some time: https://wordpress.org/plugins/clean-image-filenames/

[ramshorst]

@leonstafford having fun I see ;) thanks for all the great work you do. WP2Static makes it easy to make blazing fast websites <3