ESQL: Support null group key in more cases
#98507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for null group keys in all groupings that are backed by the PackedValuesBlockHash. This means the only groupings that don't support null keys at the moment are long/long pairs, and long/bytes_ref pairs. Those are coming next.
|
This was reviewed and approved before we opened the feature/esql public branch. |
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
This adds support for null group keys in all groupings that are backed by the PackedValuesBlockHash. This means the only groupings that don't support null keys at the moment are long/long pairs, and long/bytes_ref pairs. Those are coming next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for null group keys in all groupings that are backed by the
PackedValuesBlockHash. This means the only groupings that don't support null keys at the moment are long/long pairs, and long/bytes_ref pairs. Those are coming next.