ESQL: replace the is_null function with IS NULL and IS NOT NULL predicates #98412
Conversation
|
Documentation preview: |
|
Pinging @elastic/es-ql (Team:QL) |
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
| if (identifier.getText().equalsIgnoreCase("is_null")) { | ||
| throw new ParsingException( | ||
| source(ctx), | ||
| "is_null function is not supported anymore, please use 'is null' or " + "'is not null' constructs instead" |
There was a problem hiding this comment.
"please use is null/is not null predicates instead "
why the "+"? left over from formatting?
There was a problem hiding this comment.
Yes, formatting leftover.
| "is_null function is not supported anymore, please use 'is null' or " + "'is not null' constructs instead" | ||
| ); | ||
| } | ||
| super.exitFunctionExpression(ctx); |
There was a problem hiding this comment.
No need to call this since it's an empty function.
There was a problem hiding this comment.
Another leftover from the default override ide implementation.
| if (ctx.NOT() != null) { | ||
| return new IsNotNull(source, exp); | ||
| } else { | ||
| return new IsNull(source, exp); | ||
| } | ||
| } |
There was a problem hiding this comment.
Use the ternary operator to make it a one-liner:
return ctx. NOT() != null ? new IsNotNull(source, exp) : new IsNull(source, exp);
| | WHERE birth_date IS NULL | ||
| | KEEP first_name, last_name | ||
| ---- | ||
| -- |
There was a problem hiding this comment.
| -- |
There was a problem hiding this comment.
This would break the docs. Interesting that CI didn't catch it.
There was a problem hiding this comment.
That's strange! It should.
I'd move this example into a csv-spec and include it like the function docs do. We probably already have an example in there already.
… into is_null_is_not_null
|
@elasticsearchmachine run elasticsearch-ci/bwc |
No description provided.