EQL: Integrate TOML tests for function folding #58748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefan
added
>enhancement
>test
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
This was referenced Jun 30, 2020
costin
approved these changes
Jul 1, 2020
| import java.util.List; | ||
|
|
||
|
|
||
| public class EqlFoldSpecLoader { |
There was a problem hiding this comment.
At some point it would be good to put the JTOM utilities in a central place (maybe their own project) to avoid having to have this code duplicated in various places.
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Ross Wolf <[email protected]> (cherry picked from commit e9b1fa5)
astefan
added a commit
that referenced
this pull request
Jul 1, 2020
Co-authored-by: Ross Wolf <[email protected]> (cherry picked from commit e9b1fa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a wrap up of #57568 and most of the code originates there.
Part of #57313
Related to #57323
Pulled over more tests from EQL to tests that functions are folded correctly. It's similar in approach to our integration tests, but a little simpler since we don't have to go searching for events that match. There's also the same case_sensitive and case_insensitive toggles for tests that only work with one configuration. If neither of those are true, then the test will be checked against both, because it's assumed that the case already matches.