EQL: case sensitivity aware integration testing #58624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 28a3f55)
(cherry picked from commit 125f19d)
(cherry picked from commit bbc7215)
(cherry picked from commit 48d3b72)
(cherry picked from commit 254b5c3)
(cherry picked from commit 28d9a76)
(cherry picked from commit 545ab4a)
(cherry picked from commit b8d16d3)
(cherry picked from commit 0e742de)
Rewrite case sensitivity settings: NULL -> run both case sensitive and insensitive tests TRUE -> run case sensitive test only FALSE -> run case insensitive test only
…o case-sensitive-tests
astefan
added
>enhancement
>test
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
Closed
costin
reviewed
Jun 27, 2020
Comment on lines
696
to
699
| expected_event_ids = [67, 68, | ||
| 69, 70, | ||
| 72, 73, | ||
| 74, 75] |
There was a problem hiding this comment.
These are incorrectly formatted (as is the rest of the group under it) - the sequence has 4 items not 2 on a line.
…o case-sensitive-tests
…o case-sensitive-tests
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Jun 29, 2020
* Add DataLoader * Rewrite case sensitivity settings: NULL -> run both case sensitive and insensitive tests TRUE -> run case sensitive test only FALSE -> run case insensitive test only * Rename test_queries_supported * Add more toml tests from the Python client Co-authored-by: Ross Wolf <[email protected]> (cherry picked from commit 34d3834)
astefan
added a commit
that referenced
this pull request
Jun 29, 2020
* EQL: case sensitivity aware integration testing (#58624) * Add DataLoader * Rewrite case sensitivity settings: NULL -> run both case sensitive and insensitive tests TRUE -> run case sensitive test only FALSE -> run case insensitive test only * Rename test_queries_supported * Add more toml tests from the Python client Co-authored-by: Ross Wolf <[email protected]> (cherry picked from commit 34d3834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a wrap up of #57323 and most of the code originates there.
Part of #57313
Closes #56754
Pulled over the latest TOML integration tests from Python, which have case (in)sensitive toggles.
There's a handful more tests added, and I noticed that some of the sequence tests are failing, so I left those in the exclusions list. Also updated the HLRC to include case sensitive toggles, which was needed for the tests.
Basically to mark a test as case-sensitive only, add this to the TOML
or this to make a test case-insensitive only.
If the flags aren't set, then the test is assumed to work with both and tests are run both with case_sensitive=true and case_sensitive=false.