Semantic_text match_all with Highlighter #128702
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the missing
highlighting
for semantic_text fields when amatch_all
query is used. We guide users to use semantic highlighting to view their chunks, but highlighting does not currently return any results withmatch_all
. Highlighting is usually unnecessary for non-inference fields withmatch_all
, but it's essential forsemantic_text
fields to return the generated chunks. This change ensures those highlighting results are returned as expected.Test cases:
Only text fields
only inference fields
Both infer and non-inference fields
Some additional cases