-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Introduce partitioning in TopN operator #128135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
przemekwitek
wants to merge
234
commits into
elastic:main
Choose a base branch
from
przemekwitek:topn_partition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5b4f15
to
2db7dab
Compare
b70b245
to
2493b64
Compare
2493b64
to
cff81d9
Compare
Made with ❤️️ by updatecli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…vice (elastic#128119) SharedBlobCacheService keeps track of the free regions in a ConcurrentLinkedQueue. We use its "size()" method in three places outside of tests but unfortunately this is not a constant time operation because of the asynchronous nature of this queue. This change removes two of the uses where we only check if the queue is empty by calling the "isEmpty()" method instead.
…c#127371) Replaces the use of a SingleResultDeduplicator by refactoring the cache as a subclass of CancellableSingleObjectCache. Refactored the AllocationStatsService and NodeAllocationStatsAndWeightsCalculator to accept the Runnable used to test for cancellation. Closes elastic#123248
Ensure sufficent bytes for the start position.
* Disallow removal of regex extracted fields --------- Co-authored-by: Andrei Stefan <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]>
The Replace string result limit was fixed to 1MB, same as Repeat
When the Transform System Index has been reindexed and aliased, we should check the Transform Update index against the alias when updating the Transform Config.
In order to remove ActionType, ActionRequest will become strongly typed, referring to the ActionResponse type. As a precursor to that, this commit adds a LegacyActionRequest which all existing ActionRequest implementations now inherit from. This will allow adding the ActionResponse type to ActionRequest in a future commit without modifying every implementation at once.
* Replace irregular whitespaces * More chars
* Fail fast on invalid entitlement patches * Don't peel off `PolicyParserException` * Just catch Exception
--------- Co-authored-by: Andrei Stefan <[email protected]>
…ckerAutoFormCluster elastic#128113
* Rename and encapsulate InitializeArgs * Move ElasticsearchEntitlementChecker out of api package. It's an implementation detail that doesn't need to be exposed to the rest of the system. * Stub TestPathLookup (not yet implemented)
Entitlement instrumentation works by reflectively calling back into the entitlements lib to grab the checker. It must be fully in place before any classes are instrumented. This commit fixes a bug that was introduced by refactoring which caused the checker to not be set until after all classes were instrumented. In some situations this could lead the checker to being null when it is grab (and statically cached) by the entitlement bridge.
…LikeTests testEvaluateInManyThreads {TestCase=100 random code points matches self case insensitive with text} elastic#128705
…LikeTests testEvaluateInManyThreads {TestCase=100 random code points matches self case insensitive with keyword} elastic#128706
…ntsLifeCycleForSingleProject elastic#128707
…LikeTests testCrankyEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with text} elastic#128710
…LikeTests testCrankyEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with keyword} elastic#128711
…ildcardLikeTests testCrankyEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with text} elastic#128712
…ildcardLikeTests testCrankyEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with keyword} elastic#128713
…ildcardLikeTests testEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with text} elastic#128714
…ildcardLikeTests testEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with keyword} elastic#128715
…LikeTests testEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with keyword} elastic#128716
…LikeTests testEvaluateBlockWithNulls {TestCase=100 random code points matches self case insensitive with text} elastic#128717
More robust test for closed clients holder. Also changes IllegalStateException to AlreadyClosedException for both closed manager and holder. Resolves: elastic#128707
…stic#128650) If an index is deleted after a snapshot has written its shardGenerations file but before the snapshot is finalized, we exclude this index from the snapshot because its indexMetadata is no longer available. However, the shardGenerations file is still valid in that it is the latest copy with all necessary information despite it containing an extra snapshot entry. This is OK. Instead of dropping this shardGenerations file, this PR changes to carry it forward by updating RepositoryData and relevant in-progress snapshots so that the next finalization builds on top of this one. Co-authored-by: David Turner <[email protected]>
…lastic#128362) Starting with Lucene 10, `CharacterRunAutomaton` is no longer determinized automatically. In Elasticsearch 9, we adapted to this by eagerly determinizing automatons early (via `Regex#simpleMatchToAutomaton`). However, this introduced regression: operations like index template conflict checks, which only require intersection testing, now pay the cost of determinization—an expensive step that wasn’t needed before. In some cases, especially when many wildcard patterns are involved, determinization can even fail due to state explosion. This change removes the unnecessary determinization, restoring the pre-9.0 behavior and allowing valid index templates with many patterns to be registered again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to use TopN operator together with a collection of given partition fields in order to respond to "Give me top N results per partition field P" queries.
Example:
"Give me the last 10 trade orders per stock ticker"
This functionality will be needed in order to implement `CHANGE_POINT ... BY ..." in the subsequent PRs.