Java issues batch 4 #2549
Merged
Java issues batch 4 #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
approved these changes
May 8, 2024
specification/cluster/put_component_template/ClusterPutComponentTemplateRequest.ts
Show resolved
Hide resolved
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
* removed internal parameter `cause` * seq_no in base response optional * add optional `keep` field to removeProcessor (610) * added optional separator field to adjacencyMatrix (629) * added element_type to dense vector field (632) * definitely removed `cause` (cherry picked from commit 53edb78)
l-trotta
added a commit
that referenced
this pull request
May 8, 2024
* removed internal parameter `cause` * seq_no in base response optional * add optional `keep` field to removeProcessor (610) * added optional separator field to adjacencyMatrix (629) * added element_type to dense vector field (632) * definitely removed `cause` (cherry picked from commit 53edb78) Co-authored-by: Laura Trotta <[email protected]>
This was referenced May 8, 2024
l-trotta
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes provided in this PR:
causefrom PutComponentTemplateRequest, it's an internal parameter and should not be exposedseq_noshould be optional too, likeprimary_termkeepfield. docs + server codeseparatorfield. docs + server codeelement_type. docs + server code