Fix buckets type for multi-bucket aggregates #6639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2022
stevejgordon
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 29, 2022
Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After flattening the inheritance hierarchy for types, multi-bucket aggregates lost their derived manual handling for the buckets property which opts to avoid the use of a union by preventing the use of keyed buckets. This PR reapplies the fixup for these types as part of code generation.