-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove inheritance for code-generated types #6611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevejgordon
commented
Jul 26, 2022
- Remove inheritence for code gen of classes
- Seal request types
- Update serialization after inheritance removal
- Prevent parallel tests which seem to hang
- Fix search API test assertion
- Fix multi search test
- Rename and move some files
- Queries derive from Query type
- Update tests
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file
This was referenced Jul 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file
stevejgordon
added a commit
that referenced
this pull request
Jul 27, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 27, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 27, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Jul 27, 2022
* Remove inheritence for code gen of classes * Seal request types * Update serialization after inheritance removal * Prevent parallel tests which seem to hang * Fix search API test assertion * Fix multi search test * Rename and move some files * Queries derive from Query type * Update tests * Update test file Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.