Skip to content

[Backport 8.2] Fix field name query converter #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

using System;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using Elastic.Transport;
Expand All @@ -15,6 +17,8 @@ public sealed partial class ElasticsearchClient
{
private readonly ITransport<IElasticsearchClientSettings> _transport;

internal static ConditionalWeakTable<JsonSerializerOptions, IElasticsearchClientSettings> SettingsTable { get; } = new();

/// <summary>
/// Creates a client configured to connect to localhost:9200.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Licensed to Elasticsearch B.V under one or more agreements.
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System;
using System.Text.Json;

namespace Elastic.Clients.Elasticsearch;

internal class CustomizedNamingPolicy : JsonNamingPolicy
{
private readonly Func<string, string> _namingAction;

public CustomizedNamingPolicy(Func<string, string> namingAction) => _namingAction = namingAction;

public override string ConvertName(string name) => _namingAction(name);
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@

namespace Elastic.Clients.Elasticsearch;

internal class CustomizedNamingPolicy : JsonNamingPolicy
{
private readonly Func<string, string> _namingAction;

public CustomizedNamingPolicy(Func<string, string> namingAction) => _namingAction = namingAction;

public override string ConvertName(string name) => _namingAction(name);
}

/// <summary>
/// The built in internal serializer that the high level client Elastic.Clients.Elasticsearch uses.
/// </summary>
Expand Down Expand Up @@ -65,6 +56,8 @@ public DefaultRequestResponseSerializer(IElasticsearchClientSettings settings)
PropertyNamingPolicy = JsonNamingPolicy.CamelCase
};

ElasticsearchClient.SettingsTable.Add(Options, settings);

_settings = settings;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,16 @@ public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions
if (value.Field is null)
writer.WriteNullValue();

writer.WriteStartObject();
writer.WritePropertyName(value.Field.ToString());
WriteInternal(writer, value, options);
writer.WriteEndObject();
if (options.TryGetClientSettings(out var settings))
{
writer.WriteStartObject();
writer.WritePropertyName(settings.Inferrer.Field(value.Field));
WriteInternal(writer, value, options);
writer.WriteEndObject();
return;
}

throw new JsonException("Unable to retrieve client settings to infer field.");
}

internal abstract T? ReadInternal(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Licensed to Elasticsearch B.V under one or more agreements.
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System.Text.Json;

namespace Elastic.Clients.Elasticsearch;

internal static class JsonSerializerOptionsExtensions
{
public static bool TryGetClientSettings(this JsonSerializerOptions options, out IElasticsearchClientSettings settings) =>
ElasticsearchClient.SettingsTable.TryGetValue(options, out settings);
}
28 changes: 28 additions & 0 deletions tests/Tests/Serialization/Queries/SearchSerializationTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// Licensed to Elasticsearch B.V under one or more agreements.
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System.Threading.Tasks;
using Elastic.Clients.Elasticsearch.QueryDsl;
using Tests.Domain;
using VerifyXunit;

namespace Tests.Serialization.Queries;

[UsesVerify]
public class SearchSerializationTests : SerializerTestBase
{
[U]
public async Task Search_WithMatchQuery_SerializesInferredField_ForObjectInitializer()
{
var container = QueryContainer.Match(new MatchQuery
{
Field = Infer.Field<Project>(d => d.Description),
Query = "testing"
});

var json = SerializeAndGetJsonString(container);

await Verifier.VerifyJson(json);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
match: {
description: {
query: testing
}
}
}