Reindex doesn't support multiple Types

[dusda]

So ElasticClient.ReIndex is very handy for migrating indexes from one Type mapping to another, but what if you have more than one Type in your Index? ReIndex doesn't let you use it on an existing Index and you can't specify more than one Type when using it, so I'm left with either writing my own implementation to reindex the thing, or re-work my model to move each Type mapping into it's own index.

[shanekenney]

@dusda NEST can reindex all types within an index. You should be able to use the following as an example (from ReindexTests):

Client.Reindex<object>(r => r
    .FromIndex("sourceindex")
    .ToIndex("targetindex")

[dusda]

That...works beautifully. Thank you.

What an odd syntax, though, wouldn't it make more sense to have method signature with no generic type, at least externally?

[gmarz]

Actually, it looks like we've uncovered a bug here.

Regardless of the type specified, whether some T or just object, reindex will still search across all types.

Reindex()<T> should respect the type when executing the search portion, and we should have a non-generic Reindex() as @dusda is suggesting, that defaults to all types, but allows for specifying multiple.

[Mpdreamz]

@gmarz @russcam vote to bump to 2.0.0 beta1? 👍 from me

[russcam]

@Mpdreamz Agreed 👍