objc: add protocol support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajimehoshi
reviewed
Sep 15, 2022
|
Did you want to discuss my question first or do you agree with my conclusion? |
|
Sorry I missed that.
Hm, then p, _, _ := purego.SyscallN(objc_getProtocol, uintptr(unsafe.Pointer(n)))
return Protocol(p)Doesn't this SyscallN return a pointer to Protocol instead of a Protocol itself? |
hajimehoshi
reviewed
Sep 15, 2022
hajimehoshi
requested changes
Sep 15, 2022
hajimehoshi
reviewed
Sep 15, 2022
hajimehoshi
reviewed
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for ebitengien#2326.
Should the
GetProtocolfunction return a pointer to Protocol or just Protocol? The Objective-C runtime returns a pointer however there is never a reason for us to need to dereference this pointer so I thought it best to just remove it.