Support pinning the rustup version #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2025
dtolnay
requested changes
May 22, 2025
|
Alright, makes sense. I will update the PR accordingly asap. |
|
What is the intended behavior of - uses: dtolnay/rust-toolchain
with:
rustup-version: Nwhen the runner contains a preinstalled rustup that is different from N? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to pin the
rustupversion used in this action, it defaults (to be non-breaking) to the current latest version (1.28.2). This would need updating in the future as soon as newrustupversions are available.Note: I'm not one hundred percent certain that setting the env var on Windows works the same as on Linux-based systems. I have the suspicion we might need to use theEDIT: The CI runs seem to suggest setting the env var worked as expected.setcommand on Windows. Please feel free to suggest how this is best tested.