Skip to content

Fix issue #44: Add CI workflow and update Husky configuration #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

bhouston
Copy link
Member

@bhouston bhouston commented Mar 7, 2025

Fix Issue #44: Add CI Workflow and Update Husky Configuration

This PR implements recommendations 2 and 3 from issue #44:

Changes:

  1. Added CI Workflow:

    • Created a new GitHub Actions workflow file (.github/workflows/ci.yml)
    • Configured to run on all pushes and PRs to main
    • Performs linting, type checking, and build validation
    • Based on the workflow from mycoder-websites repository
  2. Fixed Husky Configuration:

    • Updated pre-commit hook to properly run pre-commit-check
    • Added pre-push hook with the same validation
    • Made both hooks executable
    • Updated lint-staged configuration in package.json
  3. Added .nvmrc file:

    • Created .nvmrc with Node.js version 18 to ensure consistent Node.js versions

These changes will help prevent broken builds from being committed or pushed, even if developers bypass the pre-commit hooks locally.

Closes #44

@bhouston bhouston merged commit 0456a85 into main Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving husky pre-commit hooks.
1 participant