Skip to content

[release/8.0.1xx-preview5] Update dependencies from dotnet/aspnetcore #15415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 2, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: f699cffc-7bdd-4a2a-c545-08db62d8f0bf
  • Build: 20230602.2
  • Date Produced: June 3, 2023 1:58:57 AM UTC
  • Commit: fe4f0d09305ca73aa19976b4521e5c4e223b080e
  • Branch: refs/heads/release/8.0-preview5

…0230531.1

Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop
 From Version 7.0.0 -> To Version 8.0.0-preview.5.23281.1
@ghost ghost added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jun 2, 2023
@jonathanpeppers
Copy link
Member

@Eilon maybe you can help, I was trying to fix: https://github.com/aspnet/AspNetCore-ManualTests/issues/2125

Which had a gold bar due to outdated ASP.NET packages:

image

Now I'm past the gold bar, but the web page is still white -- and there are some test failures now.

@jonathanpeppers
Copy link
Member

jonathanpeppers commented Jun 2, 2023

After using edge://inspect, I see the JavaScript error in the browser:

blazor.webview.js:1  Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'beginInvokeJSFromDotNet')
    at blazor.webview.js:1:43911
    at Object.Ct [as start] (blazor.webview.js:1:44487)

Which looks like this line:

image

mkArtakMSFT pushed a commit to dotnet/aspnetcore that referenced this pull request Jun 3, 2023
# [Blazor] Fix WebView JavaScript boot bug

Fixes an issue where the WebView IPC receiver starts before the JavaScript dispatcher object gets initialized, preventing all Blazor Hybrid apps from starting.

## Description

Due to some recent major changes in this area, a WebView-specific initialization order bug was introduced that prevents Blazor Hybrid apps from booting correctly.

Unblocks dotnet/maui#15415

## Customer Impact

Very large. All Blazor Hybrid apps will fail to start without a workaround.

## Regression?

- [X] Yes
- [ ] No

Regressed from .NET 8.0 Preview 4

## Risk

- [ ] High
- [ ] Medium
- [X] Low

The fix is very isolated and unlikely to introduce another bug.

## Verification

- [X] Manual (required)
- [ ] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [X] N/A
…0230602.2

Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop
 From Version 7.0.0 -> To Version 8.0.0-preview.5.23302.2
dotnet-bot pushed a commit to dotnet/dotnet that referenced this pull request Jun 3, 2023
…w JavaScript boot bug (#48594)

# [Blazor] Fix WebView JavaScript boot bug

Fixes an issue where the WebView IPC receiver starts before the JavaScript dispatcher object gets initialized, preventing all Blazor Hybrid apps from starting.

## Description

Due to some recent major changes in this area, a WebView-specific initialization order bug was introduced that prevents Blazor Hybrid apps from booting correctly.

Unblocks dotnet/maui#15415

## Customer Impact

Very large. All Blazor Hybrid apps will fail to start without a workaround.

## Regression?

- [X] Yes
- [ ] No

Regressed from .NET 8.0 Preview 4

## Risk

- [ ] High
- [ ] Medium
- [X] Low

The fix is very isolated and unlikely to introduce another bug.

## Verification

- [X] Manual (required)
- [ ] Automated

## Packaging changes reviewed?

- [ ] Yes
- [ ] No
- [X] N/A

Original commit: dotnet/aspnetcore@fe4f0d0

[[ commit created by automation ]]
@rmarinho rmarinho merged commit 27931be into release/8.0.1xx-preview5 Jun 4, 2023
@rmarinho rmarinho deleted the darc-release/8.0.1xx-preview5-d1d48fee-44a1-42fb-b226-d029f5301e5b branch June 4, 2023 11:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants